Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
gameroman
force-pushed
the
fix-search
branch
2 times, most recently
from
e7f832a to
b283763
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughDebounce-based URL synchronisation and the debounce import are removed. In app/components/Header/SearchBox.vue, URL updates now occur only when the current route is 'search' via Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
|
I need to fix the tests now |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/components/Header/SearchBox.vue (1)
47-49: Consider adding a type guard forroute.name.
route.namecan bestring | symbol | null | undefined, whilstpagesWithLocalFilteris aSet<string>. AlthoughSet.has()handles mismatched types gracefully at runtime (returningfalse), an explicit type check would satisfy strict type safety. The same pattern appears on line 59.♻️ Proposed type-safe guard
- if (pagesWithLocalFilter.has(route.name)) { + if (typeof route.name === 'string' && pagesWithLocalFilter.has(route.name)) {Apply the same pattern at line 59.
As per coding guidelines: "Ensure you write strictly type-safe code".
|
I think this is a duplicate of #1107 unfortunately |
3 participants
Searches on enter key press